fix(MeshLoadBalancingStrategy): set all priorities equal if localityAware is disabled #11980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegy case Also fix existing assertion. Signed-off-by: Mike Beaumont <[email protected]>
…wareness is disabled Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
requested review from
bartsmykla and
lukidzi
and removed request for
a team
michaelbeaumont
commented
Nov 5, 2024
lukidzi
approved these changes
Nov 6, 2024
michaelbeaumont
added a commit
to michaelbeaumont/kuma
that referenced
this pull request
Nov 6, 2024
Changed in kumahq#11980 to really check both zones were being used. Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
to michaelbeaumont/kuma
that referenced
this pull request
Nov 6, 2024
The uni MeshService is autogenerated, without the namespace tag, since kumahq#11978 and the first condition in "should fallback only to first zone" was fixed in kumahq#11980. Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Nov 6, 2024
The uni MeshService is autogenerated, without the namespace tag, since #11978 and the first condition in "should fallback only to first zone" was fixed in #11980. This caused the test to start failing on master. Signed-off-by: Mike Beaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We already set
priority: 1for remote zones infillRemoteMeshServicesso we need to explicitly setpriority: 0if we don't want locality awareness.Also fix an insufficient condition in an existing case, where we weren't verifying that requests really go to all zones, only that it's OK if they do.
Supporting documentation
Fixes #11968